BlockVariationPicker: remove unused withSelect #53100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
|
Flaky tests detected in e035f76. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5690153300
|
tyxla
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at usages of the
getBlockVariationsselectors, I noticed a weird usage in mobileBlockVariationPicker, where variations for thecolumnsblock are connected asdateprop. But this prop is not used at all, and the component uses thevariationsprop instead, passed from the parent.It was added in #23828, and is probably a leftover as the PR was incrementally reworked in its 31 commits. This PR removes that
withSelectcall.As a drive-by I'm also removing calls of
useMemo, as it's unusual, and not very useful, to wrap normal JSX markup inuseMemo. The hook doesn't even declare all its dependencies correctly, leading to ESLint warnings, and the component won't also correctly react to prop changes.